ronething commented on PR #2590:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2590#issuecomment-3388168070
Hi @MISAKIGA ,
Thank you for submitting this PR and identifying this issue!
We noticed that PR #2592 has already addressed this problem with a more
comprehensive approach. Could you take a look at that PR and see if it covers
your use case?
While reviewing your implementation, we found a potential edge case: when
a resource is deleted, the corresponding SSL configuration in the data plane
might be removed immediately, which could cause issues if other resources in
the cluster are still referencing it. PR #2592 includes additional logic to
handle this scenario.
Would you mind reviewing #2592 to see if it fully addresses what you were
trying to fix? If you have any concerns or suggestions for improvement, we'd
love to hear your feedback on that PR. Alternatively, if you'd still like to
continue working on this one, we're happy to discuss how to handle the edge
case mentioned above.
Thanks again for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
