jizhuozhi commented on code in PR #12448:
URL: https://github.com/apache/apisix/pull/12448#discussion_r2467726305
##########
apisix/schema_def.lua:
##########
@@ -488,6 +488,18 @@ local upstream_schema = {
description = "group name",
type = "string",
},
+ metadata_match = {
Review Comment:
Hello @Baoyuantop , because metadata is a noun. In our user communication,
many people said that they mistakenly thought it was a label without side
effects. Therefore, we used metadata_match with verb semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]