Revolyssup opened a new pull request, #12714: URL: https://github.com/apache/apisix/pull/12714
There is a big performance difference between APISIX 3.10 and 2.13 when no plug-ins are enabled. After comparing the flame graphs of APISIX 3.10 and 2.13 versions, it can be clearly seen that the biggest difference is in the pick_server function. After comparing the function codes of the two versions, it is found that the code of version 3.10 has added logic to traverse all upstream nodes, and when there are more upstream nodes during performance testing, so the difference is more obvious. After backtracking the changes, it was found that the changes traversing all upstream nodes were introduced by this pr https://github.com/apache/apisix/pull/7594. change point 1. Remove https://github.com/apache/apisix/blob/73618d48f32e263228f1a0a0df71fbc3ec5d9a54/apisix/balancer.lua#L198-L202 from the request path, and escape it to upstream's `check_schema` function to implement this logic 2. Illegal ipv6 addresses are directly rejected in the admin api - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) <!-- Note 1. Mark the PR as draft until it's ready to be reviewed. 2. Always add/update tests for any changes unless you have a good reason. 3. Always update the documentation to reflect the changes made in the PR. 4. Make a new commit to resolve conversations instead of `push -f`. 5. To resolve merge conflicts, merge master instead of rebasing. 6. Use "request review" to notify the reviewer after making changes. 7. Only a reviewer can mark a conversation as resolved. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
