Baoyuantop commented on code in PR #12720:
URL: https://github.com/apache/apisix/pull/12720#discussion_r2501524148


##########
apisix/stream/plugins/mqtt-proxy.lua:
##########
@@ -156,8 +156,9 @@ function _M.preread(conf, ctx)
         return 503
     end
 
-    if res.protocol and res.protocol ~= conf.protocol_name then
-        core.log.error("expect protocol name: ", conf.protocol_name,
+    local protocol_name = conf.protocol_name or "MQTT"

Review Comment:
   No default value is needed here since we've already defined the default 
value in the schema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to