beardnick opened a new pull request, #12751:
URL: https://github.com/apache/apisix/pull/12751
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #12482
##### Notice
- I have updated the `limit-count-redis.lua` and
`limit-count-redis-cluster.lua` files to ensure they now support rate-limiting
during the log phase.
- I referred to the `limit-conn-redis.lua` file as a guide while
implementing rate-limiting in the log phase.
- To ensure a clean testing environment, I added the
`require("lib.test_redis").flush_all()` function to every Redis rate-limiting
test case. Without this addition, the tests could fail unpredictably.
- I have adjusted the expected results in `limit-req-redis.t` and
`limit-req-redis-cluster.t` test cases. After thorough verification, the
correct behavior is `[200, 403, 403, 403]`. Previously, the results appeared as
`[403, 403, 403, 403]` due to Redis not being properly cleaned beforehand.
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not,
please discuss on the [APISIX mailing
list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
