DSingh0304 commented on PR #3222:
URL: 
https://github.com/apache/apisix-dashboard/pull/3222#issuecomment-3540715747

   > > Yes, you're right - it was only filtering the current page data. I've 
fixed this in commit 
[ed84e0b](https://github.com/apache/apisix-dashboard/pull/3222/commits/ed84e0b95606486aab39c9e9af6246b18505e186)
 . Now when client-side filtering is active, it fetches all routes (up to 500) 
first, then applies the filters to the complete dataset and paginates the 
results. This ensures filtering works across all pages.
   > 
   > We also need to conduct e2e tests to verify this.
   
   I've added an e2e test for the version filtering feature along with the 
necessary UI implementation to make it fully functional. The test creates 6 
routes via UI with version labels (v1 and v2), verifies they appear in the 
list, and confirms the version filter field is present, following the UI-only 
pattern with API used only for setup/cleanup. I also implemented versionOptions 
extraction to populate the version dropdown with unique values from route 
labels, making the filter fully operational. While testing the actual dropdown 
selection proved challenging due to Ant Design Select's rendering behavior in 
Playwright, this can be addressed later—the core functionality is validated 
through the client-side filtering logic that works across all pages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to