Baoyuantop commented on code in PR #12794:
URL: https://github.com/apache/apisix/pull/12794#discussion_r2625851797
##########
t/xrpc/pingpong.t:
##########
@@ -510,9 +510,9 @@ call pingpong's log, ctx unfinished: false
}
}
)
- if code >= 300 then
+ if code ~= 400 then
ngx.status = code
- ngx.say(body)
+ ngx.say("expected 400 for invalid superior_id, got " .. code
.. ": " .. body)
Review Comment:
Could you explain why this part was modified?
##########
t/xrpc/pingpong.t:
##########
@@ -779,3 +779,49 @@ qr/connect to \S+ while prereading client data/
connect to 127.0.0.3:1995 while prereading client data
connect to 127.0.0.1:1995 while prereading client data
--- stream_conf_enable
+
+
+
+=== TEST 22: cleanup
Review Comment:
I think this cleaning is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
