apaloleg commented on PR #12826: URL: https://github.com/apache/apisix/pull/12826#issuecomment-3677056270
Hi! Thank you @ranxuxin001 for the previous attempt to implement incremental updates for APISIX! The core idea was really solid and greatly inspired this solution here. Unfortunately, when I tried to build on that solution for radixtree_host_uri, I couldn't quite get it working properly in my tests — it's very possible I didn't fully understand the original intent. So, I decided to take a slightly different path by directly passing and retrieving sub-routers in the host routes. This allowed me to achieve stable incremental updates, but I'm well aware there might be a more elegant or cleaner way to do it. If you or anyone else has alternative ideas or suggestions, I'd genuinely love to hear them and am happy to adjust the implementation! Additionally, in this PR was also: Added proper handling of the route status field (0/1) during create/update/delete operations. Removed storage of sync_tb in the privileged agent to prevent unnecessary data accumulation across processes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
