nic-6443 commented on code in PR #12831:
URL: https://github.com/apache/apisix/pull/12831#discussion_r2646475710
##########
apisix/stream/plugins/mqtt-proxy.lua:
##########
@@ -156,7 +156,7 @@ function _M.preread(conf, ctx)
return 503
end
- if res.protocol and res.protocol ~= conf.protocol_name then
+ if conf.protocol_name and res.protocol and res.protocol ~=
conf.protocol_name then
Review Comment:
This check is meaningless. After declaring the default value,
`conf.protocol_name` will definitely have a value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
