Baoyuantop commented on code in PR #12825:
URL: https://github.com/apache/apisix/pull/12825#discussion_r2647356515
##########
apisix/plugins/file-logger.lua:
##########
@@ -79,17 +82,43 @@ local _M = {
}
+local function get_configured_path(conf)
+ if conf.path then
+ return conf.path
+ end
+
+ local metadata = plugin.plugin_metadata(plugin_name)
+ if metadata and metadata.value and metadata.value.path then
+ return metadata.value.path
+ end
+
+ return nil, "property \"path\" is required"
Review Comment:
Hi @TaeyeongKwak, I submitted a suggested change and committed suggestion
for this comment, but it seems the error message in the test also needs to be
fixed. Could you please help me with that? It's located in
t/plugin/file-logger.t. (TEST 1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
