9268 opened a new pull request, #12867:
URL: https://github.com/apache/apisix/pull/12867

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   This PR fixes a performance issue introduced by #12353 where all worker 
processes were fetching nacos service discovery information, causing 
unnecessary network requests and JSON parsing overhead per requests.
   
   **Changes made:**
   1. **Restricted nacos discovery to privileged agent only** - Only the 
privileged agent process now fetches service information from nacos servers
   2. **Added LRU cache optimization** - Worker processes use 
version-controlled LRU cache to avoid repeated JSON parsing
   3. **Improved performance** - Reduced shared memory access and eliminated 
redundant JSON decoding
   
   **Performance improvements:**
   - Eliminates duplicate nacos API calls from multiple worker processes
   - Reduces JSON parsing overhead through LRU caching
   - Maintains data consistency through version control mechanism
   
   
   #### Which issue(s) this PR fixes:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   -->
   Fixes #12353 
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to