shreemaan-abhishek commented on code in PR #12998: URL: https://github.com/apache/apisix/pull/12998#discussion_r2791346226
########## t/plugin/limit-count-consumer-group-credentials.t: ########## @@ -0,0 +1,399 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +use t::APISIX 'no_plan'; + +repeat_each(1); +no_long_string(); +no_root_location(); + +add_block_preprocessor(sub { + my ($block) = @_; + if ((!defined $block->error_log) && (!defined $block->no_error_log)) { + $block->set_value("no_error_log", "[error]"); + } + if (!defined $block->request) { + $block->set_value("request", "GET /t"); + } +}); + +run_tests(); + +__DATA__ + +=== TEST 1: setup consumer group with limit-count plugin +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/consumer_groups/test_group', + ngx.HTTP_PUT, + [[{ + "plugins": { + "limit-count": { + "count": 2, + "time_window": 60, + "rejected_code": 429, + "key": "remote_addr", + "policy": "local" + } + } + }]] + ) + + if code >= 300 then + ngx.status = code + end + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 2: setup consumer with group_id (no direct plugins) +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/consumers/jack', + ngx.HTTP_PUT, + [[{ + "username": "jack", + "group_id": "test_group" + }]] + ) + + if code >= 300 then + ngx.status = code + end + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 3: setup credentials via credentials endpoint +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/consumers/jack/credentials/cred-jack', + ngx.HTTP_PUT, + [[{ + "id": "cred-jack", + "plugins": { + "key-auth": { + "key": "auth-jack" + } + } + }]] + ) + + if code >= 300 then + ngx.status = code + end + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 4: setup route with key-auth +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/routes/1', + ngx.HTTP_PUT, + [[{ + "plugins": { + "key-auth": {} + }, + "upstream": { + "nodes": { + "127.0.0.1:1980": 1 + }, + "type": "roundrobin" + }, + "uri": "/hello" + }]] + ) + + if code >= 300 then + ngx.status = code + end + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 5: verify rate limiting works (all 3 requests in one test) +--- pipelined_requests eval +[ + "GET /hello", "GET /hello", "GET /hello" +] +--- more_headers +apikey: auth-jack +--- error_code eval +[200, 200, 429] + + + +=== TEST 6: setup second consumer group with higher limit +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/consumer_groups/premium_group', + ngx.HTTP_PUT, + [[{ + "plugins": { + "limit-count": { + "count": 10, + "time_window": 60, + "rejected_code": 429, + "key": "remote_addr", + "policy": "local" + } + } + }]] + ) + + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 7: setup premium consumer with credentials +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + + local code, body = t('/apisix/admin/consumers/jane', + ngx.HTTP_PUT, + [[{ + "username": "jane", + "group_id": "premium_group" + }]] + ) + + if code >= 300 then + ngx.status = code + ngx.say(body) + return + end + + code, body = t('/apisix/admin/consumers/jane/credentials/cred-jane', + ngx.HTTP_PUT, + [[{ + "id": "cred-jane", + "plugins": { + "key-auth": { + "key": "auth-jane" + } + } + }]] + ) + + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 8: verify premium consumer has higher limit +--- pipelined_requests eval +[ + "GET /hello", "GET /hello", "GET /hello", "GET /hello", "GET /hello", + "GET /hello", "GET /hello", "GET /hello", "GET /hello", "GET /hello", + "GET /hello" +] +--- more_headers +apikey: auth-jane +--- error_code eval +[200, 200, 200, 200, 200, 200, 200, 200, 200, 200, 429] + + + +=== TEST 9: setup consumer with both direct plugins and group +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + + local code, body = t('/apisix/admin/consumers/mixed_user', + ngx.HTTP_PUT, + [[{ + "username": "mixed_user", + "group_id": "test_group", + "plugins": { + "response-rewrite": { + "headers": { + "X-Consumer-Plugin": "direct" + } + } + } + }]] + ) + + if code >= 300 then + ngx.status = code + ngx.say(body) + return + end + + code, body = t('/apisix/admin/consumers/mixed_user/credentials/cred-mixed', + ngx.HTTP_PUT, + [[{ + "id": "cred-mixed", + "plugins": { + "key-auth": { + "key": "auth-mixed" + } + } + }]] + ) + + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 10: verify both consumer and group plugins apply together +--- request +GET /hello +--- more_headers +apikey: auth-mixed +--- response_headers +X-Consumer-Plugin: direct +--- response_body +hello world + + + +=== TEST 11: verify group rate limit applies with mixed config +--- pipelined_requests eval +[ + "GET /hello", "GET /hello", "GET /hello" +] +--- more_headers +apikey: auth-mixed +--- error_code eval +[200, 200, 429] + + + +=== TEST 12: setup consumer with direct limit-count that overrides group config +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + + local code, body = t('/apisix/admin/consumers/override_user', + ngx.HTTP_PUT, + [[{ + "username": "override_user", + "group_id": "test_group", + "plugins": { + "limit-count": { + "count": 5, + "time_window": 60, + "rejected_code": 429, + "key": "remote_addr", + "policy": "local" + } + } + }]] + ) + + if code >= 300 then + ngx.status = code + ngx.say(body) + return + end + + code, body = t('/apisix/admin/consumers/override_user/credentials/cred-override', + ngx.HTTP_PUT, + [[{ + "id": "cred-override", + "plugins": { + "key-auth": { + "key": "auth-override" + } + } + }]] + ) + + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 13: verify consumer direct plugin overrides group plugin +--- pipelined_requests eval +[ + "GET /hello", "GET /hello", "GET /hello", "GET /hello", "GET /hello", + "GET /hello" +] +--- more_headers +apikey: auth-override +--- error_code eval +[200, 200, 200, 200, 200, 429] + + + +=== TEST 14: cleanup Review Comment: get rid of this test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
