shreemaan-abhishek opened a new pull request, #13008:
URL: https://github.com/apache/apisix/pull/13008

   ### Description
   
   When handling HTTPS requests, the `ssl_client_hello_phase` span was never 
exported
   to the OpenTelemetry collector, and all subsequent HTTP phase spans (e.g.
   `apisix.phase.access`, `resolve_dns`, `apisix.phase.header_filter`) were 
incorrectly
   nested as children of the SSL span instead of being independent top-level 
spans.
   
   This was caused by  `inject_core_spans()`, only `root_span.child_ids` were 
exported — the root span itself (`ssl_client_hello_phase`) was silently dropped.
   
   > about otlp config.yaml modification
   
   Enable `append: true` for the file exporter to use O_APPEND mode.
   Without it, after the test truncates data-otlp.json externally, it will 
breaks Lua's file:lines() that uses strlen internally.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to