juzhiyuan commented on a change in pull request #619:
URL: https://github.com/apache/apisix-dashboard/pull/619#discussion_r514012072
##########
File path: .github/workflows/frontend-e2e-test.yml
##########
@@ -0,0 +1,31 @@
+name: Front-end e2e test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ frontend-e2e:
+ name: Front-end e2e test
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Setup Node.JS environment for Front-end
Review comment:
`.js`
##########
File path: .github/workflows/frontend-e2e-test.yml
##########
@@ -0,0 +1,31 @@
+name: Front-end e2e test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ frontend-e2e:
+ name: Front-end e2e test
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Setup Node.JS environment for Front-end
+ uses: actions/setup-node@v1
+ with:
+ node-version: 14.x
Review comment:
10.x 12.x 14.x, currently 14.x is enough
##########
File path: .github/workflows/frontend-e2e-test.yml
##########
@@ -0,0 +1,31 @@
+name: Front-end e2e test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ frontend-e2e:
+ name: Front-end e2e test
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Setup Node.JS environment for Front-end
+ uses: actions/setup-node@v1
+ with:
+ node-version: 14.x
+
+ - name: Install Front-end dependencies
+ run: yarn install
+
+ - name: start Front-end and Test
Review comment:
1. `Start`
2. `then test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
