nic-6443 commented on code in PR #13019:
URL: https://github.com/apache/apisix/pull/13019#discussion_r2850442863


##########
t/plugin/limit-req.t:
##########
@@ -452,7 +452,7 @@ passed
 --- more_headers
 apikey: auth-jack
 --- error_code eval
-[403, 403, 403, 403]
+[200, 403, 403, 403]

Review Comment:
   @janiussyafiq I can understand your explanation, but why could the previous 
code pass this test case? The previous key included `ctx.conf_version`. When 
the consumer is updated, `ctx.conf_version` will change, so the key becomes a 
brand-new key. According to your explanation, the first request should also be 
allowed too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to