Baoyuantop commented on code in PR #13040:
URL: https://github.com/apache/apisix/pull/13040#discussion_r2881333009
##########
ci/pod/docker-compose.plugin.yml:
##########
@@ -123,6 +123,31 @@ services:
volumes:
-
./ci/pod/kafka/kafka-server/kafka_scram_jaas.conf:/opt/bitnami/kafka/config/kafka_jaas.conf:ro
+ ## Kafka 4.x for api_version=2 verification (KRaft mode, same family as
kafka-server1/2/3)
+ kafka-server4-kafka4:
+ image: bitnamilegacy/kafka:4.0.0
Review Comment:
Why not use apache/kafka:4.0.0?
##########
apisix/plugins/kafka-logger.lua:
##########
@@ -129,6 +129,15 @@ local schema = {
producer_max_buffering = {type = "integer", minimum = 1, default =
50000},
producer_time_linger = {type = "integer", minimum = 1, default = 1},
meta_refresh_interval = {type = "integer", minimum = 1, default = 30},
+ -- Kafka Produce API version. Default 0 for backward compatibility.
+ -- Kafka 4.x drops support for magic0 and magic1. Use 2 for Kafka 4.x.
+ api_version = {
+ type = "integer",
+ default = 0,
Review Comment:
https://github.com/doujiang24/lua-resty-kafka/blob/master/lib/resty/kafka/producer.lua#L337
I checked the code in the upstream repository again and found that the
default value is inconsistent with the documentation, so the default value
should be 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
