ShiningRush commented on a change in pull request #2556:
URL: https://github.com/apache/apisix/pull/2556#discussion_r514066039



##########
File path: t/discovery/eureka.t
##########
@@ -26,7 +26,8 @@ apisix:
   node_listen: 1984
   config_center: yaml
   enable_admin: false
-  discovery: eureka
+  discovery:
+    - eureka
 

Review comment:
       We can also move all discovery configuration to here, it would be 
better.Such as 
   ```
   discovery:
     eureka:
       host: [""]
       prefix: ""
       ...
     consul:
       uri: ""
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to