pbaranow commented on issue #2726:
URL:
https://github.com/apache/apisix-ingress-controller/issues/2726#issuecomment-3997844132
I observed the same issue on our cluster. In our case 5 minutes startup was
observed on the cluster where `ApisixUpstream` objects are configured.
I reproduced this issue on a dev cluster, where I had only `ApisixRoute` and
`ApisixConsumer` objects configured. After adding `ApisixUpstream` object
startup time went up from a few seconds to 5 minutes.
I passed the logs to an AI Agent and it pointed out that ApisixUpstream
controller is initialized without a `Readier`:
```
// internal/manager/controllers.go
&apiv2.ApisixUpstream{}: &controller.ApisixUpstreamReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Log:
ctrl.LoggerFrom(ctx).WithName("controllers").WithName(types.KindApisixUpstream),
Updater: updater,
// MISSING: Readier: readier,
},
```
and that later `Done()` function is not called
```
// internal/controller/apisixupstream_controller.go
func (r *ApisixUpstreamReconciler) Reconcile(ctx context.Context,
req ctrl.Request) (ctrl.Result, error) {
// MISSING: defer r.Readier.Done(&apiv2.ApisixUpstream{},
req.NamespacedName)
// ...
}
```
It also found that similar case is for `ApisixPluginConfig` objects.
I suppose an Expert from this area needs to take a look at this, to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
