twellck commented on PR #12859: URL: https://github.com/apache/apisix/pull/12859#issuecomment-4101667237
Hi @Baoyuantop @moonming, thanks for the feedback. I've rebased on the latest master and simplified the PR to only the minimal change, simply adding IPv6 listen directives for PROXY Protocol when enable_ipv6 is enabled (~4 lines in ngx_tpl.lua), with related tests (so ~67 lines overall). I still believe there's value in standardising how listeners are managed across the configuration. I've opened a separate issue (#13112) to discuss the approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
