ArnaudCHT commented on code in PR #916:
URL: https://github.com/apache/apisix-helm-chart/pull/916#discussion_r2982269836
##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -52,6 +52,7 @@ deployment:
nodeSelector: {}
tolerations: []
affinity: {}
+ imagePullSecrets: []
Review Comment:
Hello @Baoyuantop,
Thanks for the review! I've updated the template to align with the main
apisix chart — `imagePullSecrets` now accepts a string array and renders using
`range` + `- name: {{ . }}`.
Here are the test cases:
```bash
# Test with global.imagePullSecrets
helm template . -s templates/deployment.yaml \
--set 'global.imagePullSecrets[0]=global-registry-secret'
# Test with deployment.imagePullSecrets (local override)
helm template . -s templates/deployment.yaml \
--set 'deployment.imagePullSecrets[0]=my-registry-secret'
# Test priority: deployment takes precedence over global
helm template . -s templates/deployment.yaml \
--set 'global.imagePullSecrets[0]=global-registry-secret' \
--set 'deployment.imagePullSecrets[0]=my-registry-secret'
# Test standalone (no imagePullSecrets)
helm template . -s templates/deployment.yaml
```
All cases render correctly. Let me know if anything else needs to be
adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
