okaybase opened a new pull request, #13442: URL: https://github.com/apache/apisix/pull/13442
### Description The branch uses a stale `ok` variable from `fill_node_info()` to check whether `fetch_cert` and `fetch_pkey` succeeded, instead of checking the `cert` and `key` variables they actually return. Since `ok` was already `true` at that point, both error branches were unreachable — if either fetch returned `false`, the function would silently proceed with an invalid value rather than returning a 503 error. ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) <!-- Note 1. Mark the PR as draft until it's ready to be reviewed. 2. Always add/update tests for any changes unless you have a good reason. 3. Always update the documentation to reflect the changes made in the PR. 4. Make a new commit to resolve conversations instead of `push -f`. 5. To resolve merge conflicts, merge master instead of rebasing. 6. Use "request review" to notify the reviewer after making changes. 7. Only a reviewer can mark a conversation as resolved. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
