membphis commented on PR #13346: URL: https://github.com/apache/apisix/pull/13346#issuecomment-4562499808
Follow-up after the latest update: The two previous P1 code blockers look fixed now: - `secret` is required by the plugin schema and covered by schema tests. - The Debian runtime image installs `libxslt1.1`, so the `lua-resty-saml` native module should have the required runtime library. One small docs mismatch still needs to be fixed before merge: ### [P2] Chinese docs still mark `secret` as optional - Problem: `docs/zh/latest/plugins/saml-auth.md` still shows `secret` as `必填 = 否`, while the plugin schema now requires `secret` and the English docs show it as required. - Why this blocks merge: Chinese users following the docs can omit `secret`, but the Admin API will reject the config. The row also misses the important note that the value must be identical on all APISIX nodes for session verification across workers/reloads. - Evidence: `apisix/plugins/saml-auth.lua` includes `"secret"` in the required list; `docs/en/latest/plugins/saml-auth.md` marks `secret` as `True`; `docs/zh/latest/plugins/saml-auth.md` still marks it as `否`. - Suggested fix: change the Chinese `secret` row to `必填 = 是` and mirror the English description that the value must be identical on all APISIX nodes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
