francescodedomenico commented on PR #13178: URL: https://github.com/apache/apisix/pull/13178#issuecomment-4659967715
Hello @nic-6443 and @mbsjed I started working on this because I really needed it myself (especially being able to declare different OIDC clients and forward cookies only to specific subpaths). My initial take was to directly expose the resty session configuration in order to take full advantage of the third party library, in my opinion apisix should not have an opinionated approach on how this library is used by mapping/remapping it's configuration. That said, I changed the initial implementation due to the @Baoyuantop suggestion that also makes sense, deprecating completely the session.lifetime and exposing through the schema resty.session configuration would definitely be a breaking change, meaning that this won't reach Apisix until the 4.x release (if apisix uses semantic versioning). In order to avoid a breaking change I suggest to expose the resty.session parameters like you suggester, keep the session.lifetime parameter marking as deprecated for the 3.x and to remove it completely when apisix goes 4.x. This PR needs at least 3 reviewer also, before I move on I would love to reach some kind of consensus, I am not sure who else can/should express what kind of approach we want to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
