nic-6443 commented on issue #13101: URL: https://github.com/apache/apisix/issues/13101#issuecomment-4676895784
The crash reported here is fixed on master, but the fix hasn't shipped in a release yet. #13322 made `construct_upstream` resolve the endpoint itself when the runtime DNS field is missing (current master falls back to `resolve_endpoint` inside `apisix/plugins/ai-proxy-multi.lua`), and #13441 reworked the whole DNS/health-check path with dedicated regression tests, so the PATCH-then-crash-loop repro no longer reproduces on master; both will be in the next release after 3.16.0. One part of the suggested fix is still open though: `healthcheck_manager.lua` still indexes the `construct_upstream` return value without a nil check (lines 180 and 238), so a different trigger — e.g. removing an instance from the route while its checker is in the working pool, which makes the jsonpath lookup return nil — can still hit the same error loop. PR #13136 contains that nil-check but is written against the pre-refactor plugin code and would need a rebase down to just the healthcheck_manager hardening. I'd suggest closing this issue as fixed and tracking the remaining nil-check as a small follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
