shreemaan-abhishek commented on PR #13518: URL: https://github.com/apache/apisix/pull/13518#issuecomment-4678702629
Addressed the lint failure and review feedback in the follow-up commit: - **Lint (`tostring` global):** localized `tostring` alongside the other standard-library locals so the lj-releng global check passes. - **Verifier return contract:** the `pcall` wrapper now captures and forwards the verifier's own `(verified, err)` values instead of dropping the secondary error detail. - **Test order dependency:** merged the two malformed-signature cases into a single self-contained test that sets up its own consumer/route and exercises both the wrong-length and non-base64url signatures. Verified locally: `luacheck` + lj-releng clean, and `t/plugin/jwt-auth.t` passes (and the merged case still fails as expected when the fix is reverted). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
