nic-6443 opened a new pull request, #13536: URL: https://github.com/apache/apisix/pull/13536
### Description t/plugin/log-rotate.t TEST 4 disables log-rotate via hot reload, sleeps a fixed 2.1s, and asserts at most one rotated file exists. But the reload event reaches the privileged agent (where the rotate timer runs) asynchronously — on a loaded runner the timer can tick twice before it is unregistered, and the test fails with `got: false`. It failed twice in a row on an unrelated PR (#13515) and reproduces locally roughly 1 in 6 runs under load, against unmodified master. This rewrites the assertion to check the property the test actually cares about: rotation eventually stops after the plugin is disabled. It polls the rotated-file count and succeeds once no new file appears for two full rotation intervals (bounded by a 22s cap), which is immune to how long the agent takes to process the reload. Test-only change. ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [x] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
