bzp2010 commented on code in PR #13482:
URL: https://github.com/apache/apisix/pull/13482#discussion_r3417582741
##########
apisix/plugins/mcp/server_wrapper.lua:
##########
@@ -16,22 +16,39 @@
--
local ngx = ngx
local ngx_exit = ngx.exit
+local ngx_on_abort = ngx.on_abort
local re_match = ngx.re.match
+local pcall = pcall
local core = require("apisix.core")
local mcp_server = require("apisix.plugins.mcp.server")
+local session_limit = require("apisix.plugins.mcp.session_limit")
Review Comment:
This applies globally, right? That means no matter how many mcp-bridge
routes are configured, the total number of sessions cannot exceed the limit？
It doesn't seem to be at the router level.
##########
apisix/plugins/mcp/server_wrapper.lua:
##########
@@ -16,22 +16,39 @@
--
local ngx = ngx
local ngx_exit = ngx.exit
+local ngx_on_abort = ngx.on_abort
local re_match = ngx.re.match
+local pcall = pcall
local core = require("apisix.core")
local mcp_server = require("apisix.plugins.mcp.server")
+local session_limit = require("apisix.plugins.mcp.session_limit")
Review Comment:
This applies globally, right? That means no matter how many mcp-bridge
routes are configured, the total number of sessions cannot exceed the limit？
It doesn't seem to be at the routes level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
