shreemaan-abhishek commented on PR #13573: URL: https://github.com/apache/apisix/pull/13573#issuecomment-4767539621
Good catch, you're right. In `rules` mode `get_rules()` was treating a `resolve_var` error on `count`/`time_window` as `goto CONTINUE`, so an invalid client-controlled value silently dropped the rule. With multiple rules that bypasses the bad rule's limit, and with a single rule + `allow_degradation` it fails open entirely. Fixed: `count`/`time_window` resolution errors now `return nil, err` (rejected, same as the non-rules path); only an unresolved rule \*key\* still skips the rule, since a rule keyed on a variable absent for this request legitimately doesn't apply. Added a rules-mode regression test (verified it fails without the fix). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
