shreemaan-abhishek commented on PR #13592: URL: https://github.com/apache/apisix/pull/13592#issuecomment-4776270575
Thanks for the review. Addressed in the latest commit: 1. **nil `err` concatenation in `timer_working_pool_check`** — genuine; if `construct_upstream` returns a bare `nil`, `err` was nil and `.. err` would throw inside the timer. Fixed by defaulting `err = err or upstream or "unknown error"` before building the message. 2. **Existing checker destroyed on construct failure** — genuine; `need_destroy` stayed `true` so a transient failure dropped a valid checker. Now set `need_destroy = false` on failure so the existing checker is retained until a successful refresh. 3. **Test coverage for the `nil, err` return path** — added TEST 3 (creation timer, `return nil, "boom"`) and TEST 4 (working-pool timer, bare `nil`) so both timers are exercised on the `ok=true, upstream=nil` path, not just the thrown-error path. The new tests also use explicit returns rather than a runtime nil-index. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
