moonming commented on PR #2058: URL: https://github.com/apache/apisix-website/pull/2058#issuecomment-4788728760
## Independent audit (resolved) An independent adversarial review (no shared context, isolated worktree) checked schema validity, reliability/edge cases, JSON-LD injection, scope/breaking-changes, and verification adequacy. Findings and resolution: | Sev | Finding | Resolution | |-----|---------|------------| | **MEDIUM** | FAQ #3 schema answer used an em-dash `—` while the rendered body shows literal `---` (beta.6 has no smartypants) → violates Google's FAQ answer-must-match-page rule | **Fixed** (`5736bb90b`) — front matter reverted to `---`; re-verified the SSR answer text now matches the body byte-for-byte | | **LOW** | `Article` had no `image` → Google "missing field image" warning | **Fixed** — fall back to the site's default social card (`static.apiseven.com/202202/apache-apisix.png`, same as the site `og:image`); every article now carries an image | | **LOW** | `JSON.stringify` doesn't escape `</script>`; FAQ prose could contain `<` | **Fixed** — added a `toJsonLd` helper escaping `<` → `<`; 0 parse errors in build output | | **MEDIUM** | No automated regression test (manual SSR-grep only) | **Deferred w/ justification** — the repo has no structured-data test harness and wiring a post-build assertion into CI is out of scope for this focused PR. Manual SSR verification is documented above; filing a follow-up to add a build-output schema assertion. | Reliability, scope, and no-duplication lenses came back clean (verified against the beta.6 plugin source): the Organization-author fallback is exercised on every article, `events`/`articles` instances hit the early return untouched, and the global `schema-org` plugin only emits `WebSite`/`Organization` so there's no duplication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
