nic-6443 commented on PR #13613:
URL: https://github.com/apache/apisix/pull/13613#issuecomment-4828608494
Good catch — I looked into `graphql-proxy-cache`. With the `graphql-demo`
backend up (the plugin shard already starts it via
`docker-compose.plugin.yml`), `disk.t` and `graphql.t` pass, but `memory.t`
TEST 16 ("PURGE clears every Vary variant", added with #13523) fails
**deterministically** (same result across repeated runs, not a flake):
```
a_miss=MISS
-b_miss=MISS
+b_miss=HIT # variant b's first request hits variant a's entry
b_hit=HIT
a_after=MISS
-b_after=MISS
+b_after=HIT # PURGE didn't clear variant b
```
So in the memory strategy the cache key doesn't appear to incorporate the
`Vary` header — distinct variants share one entry (and PURGE then can't clear
them). Because these subdir tests have never run in CI, that path was never
exercised, so this looks like a latent issue rather than a test problem (I'll
confirm whether it's the feature itself vs. an environment factor).
To avoid turning this (already-approved) PR's shard red, I'd suggest
handling `graphql-proxy-cache` + that Vary case in a separate follow-up rather
than gating this one on it. Does that work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
