nic-6443 opened a new pull request, #13621:
URL: https://github.com/apache/apisix/pull/13621

   ### What this does
   
   Two test dirs were never executed by any CI workflow, so latent bugs in them 
went unnoticed:
   
   - `t/plugin/graphql-proxy-cache/*.t` is a subdir, so the `t/plugin/[a-k]*.t` 
shard glob never matched it — the same gap `dubbo-proxy` / `proxy-cache` had.
   - `t/config-center-json/*.t` was added in #12333 but never wired into 
`build.yml`.
   
   This adds both to the matrix and fixes the bugs that running them surfaced.
   
   ### Bugs found by actually running the tests
   
   **graphql-proxy-cache/memory.t — Vary-purge test wasn't hermetic.** It 
reused uri `/graphql`, which collides with `/graphql` routes left in etcd by 
earlier blocks (etcd is flushed per-file, not per-block). The colliding route 
points at a no-Vary backend, so variant separation silently broke — the test 
only passed in isolation. Fixed with a unique uri. The plugin code is 
unchanged; this was purely a test-isolation issue.
   
   **config-center-json route.t / plugin.t / stream-route.t** still carried 
`config_provider: yaml`, `use config_provider: yaml`, and the success-path 
assertions copied from the `config-center-yaml` suite, even though they feed 
`apisix_json`. Aligned them with the json provider and the yaml suite's 
reject-unknown-plugin expectations. `secret.t` needed no change — it uses the 
Vault common service.
   
   ### Placement notes
   
   `graphql-proxy-cache` goes in the `dubbo-proxy` shard rather than the 
`proxy-cache` shard because both `graphql-proxy-cache/disk.t` and `proxy-cache` 
use `/tmp/disk_cache_*` and must not share a runner. `config-center-json` sits 
next to `config-center-yaml`.
   
   All 15 affected files pass locally (363 subtests).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to