Copilot commented on code in PR #989:
URL: https://github.com/apache/apisix-helm-chart/pull/989#discussion_r3527364392
##########
charts/apisix/values.yaml:
##########
@@ -278,16 +303,54 @@ metrics:
apisix:
# -- Enable nginx IPv6 resolver
enableIPv6: true
+ # -- Enable HTTP/2 on the HTTP listeners
enableHTTP2: true
# -- Whether the APISIX version number should be shown in Server header
enableServerTokens: true
+ # -- When true, the upstream status is always written to the
`X-APISIX-Upstream-Status` response header; when false, it is written only for
5xx responses
+ showUpstreamStatusInResponseHeader: false
+
+ # -- PROXY Protocol configuration.
+ proxyProtocol:
+ # -- (int) The HTTP port that accepts the PROXY Protocol. It differs from
`service.http` ports and `apisix.admin` port:
+ # this port only accepts HTTP requests carrying the PROXY Protocol, while
the other ports only accept plain HTTP
+ # requests. If you enable the PROXY Protocol, you must use this port to
receive HTTP requests with it.
+ listenHttpPort:
+ # -- (int) The HTTPS port that accepts the PROXY Protocol.
Review Comment:
The PROXY Protocol listen ports are configurable here, but the chart's
gateway Service does not automatically expose those ports. Without also adding
them to `service.http.additionalContainerPorts` /
`apisix.ssl.additionalContainerPorts` (or creating a custom Service), users may
configure APISIX to listen on these ports but have no way to route traffic to
them.
##########
charts/apisix/values.yaml:
##########
@@ -141,41 +142,55 @@ initContainer:
tag: 1.28
autoscaling:
+ # -- Enable HorizontalPodAutoscaler for APISIX (only when useDaemonSet is
false)
enabled: false
Review Comment:
`autoscaling.enabled` is documented as only supported when `useDaemonSet` is
false, but the chart still allows enabling both. In that case the workload
becomes a DaemonSet while `templates/hpa.yaml` still renders an HPA targeting a
Deployment, which will be invalid/broken at install time. Consider enforcing
this constraint in the templates (e.g., gate HPA creation on `not
.Values.useDaemonSet`).
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -75,30 +75,24 @@ data:
enable_ipv6: {{ .Values.apisix.enableIPv6 }} # Enable nginx IPv6 resolver
enable_http2: {{ .Values.apisix.enableHTTP2 }}
enable_server_tokens: {{ .Values.apisix.enableServerTokens }} # Whether
the APISIX version number should be shown in Server header
+ show_upstream_status_in_response_header: {{
.Values.apisix.showUpstreamStatusInResponseHeader }} # when true all upstream
status write to `X-APISIX-Upstream-Status` otherwise only 5xx code
Review Comment:
Minor grammar in the inline comment: "status write" should be "status is
written" (or similar) to avoid confusion in generated config comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
