AlinsRan commented on PR #13358:
URL: https://github.com/apache/apisix/pull/13358#issuecomment-4890948607
Rebased and scoped this down to the dns fix only.
The limit-count part is no longer needed: on master #13443 already replaced
that `error("...", core.json.encode(parent))` call with `core.log.error(...) +
return nil`, and the caller now returns 500 on a nil key. So the only remaining
bug is the same `error()`-with-a-second-arg mistake in
`discovery/dns/init.lua`, which is what this PR now fixes. Dropped the
limit-count changes and the limit-count5.t test since they'd just conflict with
/ duplicate what's already on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
