AlinsRan commented on PR #12843: URL: https://github.com/apache/apisix/pull/12843#issuecomment-4901389455
Pushed an update as a maintainer (merged latest master and refined the fix): - Merge the extracted query with `&` when `conf.uri` already carries its own query string, instead of concatenating a second `?` (per Copilot's note). This matches the non-unsafe branch's `?`/`&` behavior. - Simplified the added comments. - Tests: `conf.uri` with its own query, `use_real_request_uri_unsafe` only (no `uri`) so the query reaches upstream exactly once, query with special characters, multiple `?`, and the same route with the flag disabled to confirm both variants stay consistent. @nic-6443 @moonming covered the edge cases you asked for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
