AlinsRan commented on code in PR #12885:
URL: https://github.com/apache/apisix/pull/12885#discussion_r3540505335
##########
apisix/cli/file.lua:
##########
@@ -105,7 +105,7 @@ local function resolve_conf_var(conf)
end
if new_key ~= key then
new_keys[new_key] = "dummy" -- we only care about checking the
key
- conf.key = nil
+ conf[key] = nil
Review Comment:
Done — went with the `config.yaml` custom_lua_shared_dict approach as you
suggested. Used `grep -F '${{DICT_NAME}}'` for the stale-key check instead of
`grep DICT_NAME`, since APISIX emits an `env DICT_NAME;` directive that would
match the latter regardless of the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
