nic-6443 commented on code in PR #13668:
URL: https://github.com/apache/apisix/pull/13668#discussion_r3542173302
##########
apisix/secret.lua:
##########
@@ -233,7 +233,9 @@ local function fetch(uri, use_cache)
return val
end
- return secrets_cache(uri, "", fetch_by_uri, uri)
+ -- pass the secrets conf_version so the cache re-resolves when /secrets
changes
Review Comment:
I disagree with this fix. The design of this LRU Cache dictates that all
changes take effect only after the TTL expires. Any modification, whether to
the values stored in Secret Manager or to the Secret Manager's own
configurations, must wait for the TTL to apply. This design rule is consistent.
A new issue introduced by the current fix is that any single configuration
change in Secret Manager will invalidate all cached entries, triggering a cache
storm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
