membphis commented on PR #13062: URL: https://github.com/apache/apisix/pull/13062#issuecomment-4923709488
P2 follow-up: `resolve_upstream_client_cert()` now calls `apisix_secret.fetch_secrets(..., true)` from `handle_upstream`. Cache hits are cheap, but a cold/expired cache can still call the secret manager on the proxied request path. Please consider moving upstream SSL secret resolution to config-change/background refresh, or caching a resolved SSL object by SSL resource version, so request handling only reads already-resolved cert/key material. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
