AlinsRan commented on PR #13721: URL: https://github.com/apache/apisix/pull/13721#issuecomment-5028160867
Two things a review surfaced that belong in the description of this PR. **A client-driven alternative exists and should be recorded as evaluated-but-deferred.** `WatchRequest.progress_request` / `clientv3.RequestProgress` gives the same in-stream guarantee (etcd replies with a progress response only when the watcher is already synced) without needing any server-side flag — so it would keep the #12514 benefit *and* the #13067 correctness on a stock etcd config. It is not free: lua-resty-etcd's HTTP/JSON `request_chunk` writes a fixed body then only reads, so it would need a chunked request body; the gRPC path is already bidirectional and would be a smaller change. Worth naming in the description so "change the etcd flag" doesn't read as the only option. **One doc nit on the trade-off section**: on etcd >= 3.6 the flag is renamed `--watch-progress-notify-interval` (the `--experimental-` prefix is deprecated), so the FAQ should mention both spellings, plus the 100ms lower bound. Neither blocks the direction — trading a silent-staleness optimization for the correct-but-costly compaction reload is the right call. Just make the deferred option explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
