moonming opened a new pull request, #2083: URL: https://github.com/apache/apisix-website/pull/2083
## The failure The redeploy after #2081 got further — canonical assertions passed, the Astro build ran, the docs were copied — then died in **Overlay the Astro pages onto the Docusaurus build**. The copy loop ended with: ```bash [ -f "$src/$twin" ] && cp "$src/$twin" … ``` Not every docs page has a Markdown twin. For those, that test is false, the `&&` yields 1, and because it is the loop body's **last command** the whole pipeline exits 1. Under `set -e` the step aborts — after the files are copied, but before any of the assertions below it run. That is why the log shows the route-manifest check printing its success line and the step dying immediately afterwards: it wasn't the next assertion failing, it was the loop's exit status. I spent a while looking at the canonical assertion because of it. ## The fix `if`/`fi` instead of `&&`. The loop now ends 0 and the assertions execute. Reproduced both the break and the fix in an isolated script: with `&&` the loop exits 1 despite copying every file; with `if`/`fi` it exits 0 and the following assertion runs. I also grepped the workflow for the same shape elsewhere — the only other instance (line 230) already has `|| true`, so it is safe. ## Blast radius Safe again: the step precedes the publish, so `asf-site` still holds the previous build and the live site is unaffected. But master has not been able to deploy since wave 3 merged, so wave 3 is still not live. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
