nic-6443 commented on code in PR #2813:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2813#discussion_r3700913362
##########
internal/webhook/v1/ingress_webhook.go:
##########
@@ -82,6 +83,10 @@ func (v *IngressCustomValidator) ValidateCreate(ctx
context.Context, obj runtime
return nil, fmt.Errorf("%s",
sslvalidator.FormatConflicts(conflicts))
}
+ if err := validateAnnotations(ingress); err != nil {
Review Comment:
You are right: the shipped Helm chart defaults `webhook.enabled` to true;
the `false` value is only the binary config default. The current head rejects
normal create/update and logs the documented `failurePolicy: Ignore` bypass
cases, so I consider this concern addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
