AlinsRan commented on code in PR #2826:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/2826#discussion_r3710370168


##########
internal/adc/client/executor.go:
##########
@@ -84,7 +84,11 @@ type ADCServerOpts struct {
        LabelSelector       map[string]string `json:"labelSelector,omitempty"`
        IncludeResourceType []string          
`json:"includeResourceType,omitempty"`
        TlsSkipVerify       *bool             `json:"tlsSkipVerify,omitempty"`
-       CacheKey            string            `json:"cacheKey"`
+       // CaCert is the PEM-encoded CA certificate (or bundle) the ADC server 
verifies
+       // the control plane against. Older ADC servers ignore it, and 
omitempty keeps
+       // requests without a CA bundle byte for byte what they were.
+       CaCert   string `json:"caCert,omitempty"`

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to