AlinsRan commented on PR #2834:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2834#issuecomment-5214065675
`GatewayReconciler` has the same gap this PR closes for routes:
```go
if !r.checkGatewayClass(gateway) {
return ctrl.Result{}, nil
}
```
Repointing a Gateway at a GatewayClass owned by another controller leaves
the gateway-level config behind (SSLs and the rest), so the cleanup ends up
half-done: routes get removed by this PR, the Gateway's own config does not.
`Provider.Delete` already handles `*gatewayv1.Gateway` by deleting the whole
config, so the shape is the same. Fine as a follow-up if you would rather keep
this PR scoped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
