ruanweihong-aaa commented on code in PR #13800:
URL: https://github.com/apache/apisix/pull/13800#discussion_r3755235823
##########
apisix/plugins/proxy-rewrite.lua:
##########
@@ -225,6 +247,14 @@ function _M.check_schema(conf)
if not secret.is_secret_ref(pattern) then
local test_replacement = secret.is_secret_ref(replacement)
and "" or replacement
+ if test_replacement ~= "" then
+ local err
+ test_replacement, err = escape_nginx_vars(test_replacement)
+ if err then
+ return false, "invalid regex_uri replacement(" ..
+ replacement .. "): " .. err
+ end
+ end
Review Comment:
Added an inline comment in `d1b362b` explaining that schema validation must
keep validating PCRE captures without treating NGINX variables as named
captures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
