nic-6443 opened a new pull request, #13838: URL: https://github.com/apache/apisix/pull/13838
### Description `ci/prepare_filesystem_mcp.sh` fetches the MCP servers tarball with a bare `curl -L … | tar -xz`. curl does not treat an HTTP error as a failure unless you ask it to, so when codeload answers with a 5xx the error page goes straight down the pipe and the job dies with: ``` gzip: stdin: not in gzip format tar: Child returned status 1 ##[error]Process completed with exit code 2 ``` which says nothing about the download having failed. There is also no retry, so one hiccup fails the whole `CLI Test` job. Adding `-f` makes curl exit non-zero and print the status instead, and since the script already runs under `set -euo pipefail` it now stops at the download: ``` curl: (22) The requested URL returned error: 404 ``` `--retry 3 --retry-delay 5` covers the transient case. Worth noting that plain `--retry` does retry HTTP 5xx, not just connection-level errors — verified against a local server that always answers 502, which curl requested 4 times (1 + 3 retries) before giving up. So `--retry-all-errors` is not needed here, which also keeps the invocation working on the older curl in the UBI image used by `redhat-ci.yaml` (7.61 predates that option). Two `curl -o … openssl.cnf` calls in `ci/linux-install-openresty.sh` and `ci/redhat-ci.sh` have the same missing `-f`, but they write a file that later steps read, and `ci/redhat-ci.sh` does not run under `set -e` — adding `-f` there would swap "an HTML error page in openssl.cnf" for "an empty openssl.cnf", which can be accepted silently. That needs a write-to-temp-then-move instead, so it is left out of this change. ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [x] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
