Yilialinn commented on PR #2100:
URL: https://github.com/apache/apisix-website/pull/2100#issuecomment-5326539123

   > The historical/`next` canonical rewrite still produces a local canonical 
whose target does not exist. `docs/apisix/next/plugins/mcp-bridge/` is present 
in the published `asf-site` tree and canonicalizes to 
`https://apisix.apache.org/docs/apisix/plugins/mcp-bridge/`, but the 
`release/3.17` docs used to generate the versionless Astro pages contain no 
`plugins/mcp-bridge.md`, so that final canonical target is a 404. This 
contradicts the stated canonical-target contract and leaves a crawlable 
`noindex,follow` page pointing at a missing canonical. The deployment assertion 
currently checks only the installation-guide/CORS fixtures, so it does not 
catch this case. Please make the rewrite conditional on a real latest target 
(otherwise self-canonicalize or omit the override), and validate every 
APISIX-local canonical target in the final output rather than only the samples.
   
   Thanks for catching this. Fixed in 
[`917a9b3`](https://github.com/apache/apisix-website/commit/917a9b39be14495ba21aef7d4cd98fe44b38ad1e).
   
   - `LayoutHead` now resolves the active document through Docusaurus version 
data and emits a versionless local canonical only when the same document ID 
exists in the newest released version.
   - When no released counterpart exists, as with `next/plugins/mcp-bridge/`, 
the override is omitted. The page keeps its original self-canonical while 
retaining `noindex,follow`.
   - Added an explicit deployment regression assertion for the `mcp-bridge` 
case.
   - Added a final-output validator that scans every generated HTML file and 
verifies that every `apisix.apache.org` canonical resolves to an actual file. 
It also rejects directory-only targets without an `index.html`.
   - Existing intentional API7 and APISeven plugin-documentation canonicals 
remain unchanged.
   
   The focused ESLint, workflow YAML parsing, positive/missing/empty-directory 
canonical checks, and an independent code review have passed. The full GitHub 
workflows have been triggered and are currently queued.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to