nic-6443 opened a new pull request, #13853:
URL: https://github.com/apache/apisix/pull/13853

   `t/plugin/basic-auth.t` TEST 22 fails intermittently in CI:
   
   ```
   failed to resolve secret reference: $secret://vault/test1/foo/passwd, field: 
password, err: no value
   failed to resolve secret reference in consumer auth credential, skipping 
consumer: foo
   ```
   
   The block creates a consumer whose password is 
`$secret://vault/test1/foo/passwd`, but that key is only written to Vault by 
the *next* block. So between the two, building the consumer cache resolves a 
reference that cannot exist yet and logs it at error level — and whether that 
happens while this block's log window is still open decides whether the default 
`no_error_log: [error]` trips. Nothing about what the test covers is involved.
   
   Writing the secret first removes the window. The blocks that follow still 
cover what matters: the credential resolves from Vault and authenticates.
   
   I could not make it fail on demand locally — the consumer cache is built at 
a different point there — so this is a reorder that removes the hazard rather 
than a change with a fail-before/pass-after test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to