(apisix-ingress-controller) branch master updated: fix(test): keep one recordingProvider stub so internal/controller builds (#2854)

[alinsran]

This is an automated email from the ASF dual-hosted git repository.

AlinsRan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git


The following commit(s) were added to refs/heads/master by this push:
     new c17a5857 fix(test): keep one recordingProvider stub so 
internal/controller builds (#2854)
c17a5857 is described below

commit c17a585742345953a397ca3568a1df7981b7ca0c
Author: Johannes Engler <johannes.eng...@maibornwolff.de>
AuthorDate: Thu Sep 3 06:07:03 2026 +0200

    fix(test): keep one recordingProvider stub so internal/controller builds 
(#2854)
---
 internal/controller/apisixconsumer_controller_test.go   |  5 ++++-
 .../gateway_controller_publishservice_test.go           | 17 -----------------
 2 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/internal/controller/apisixconsumer_controller_test.go 
b/internal/controller/apisixconsumer_controller_test.go
index 7d3bc49c..95c0bc0d 100644
--- a/internal/controller/apisixconsumer_controller_test.go
+++ b/internal/controller/apisixconsumer_controller_test.go
@@ -41,8 +41,10 @@ import (
 
 const testConsumerNamespace = "default"
 
-// recordingProvider records the objects passed to Delete and can be told to 
fail.
+// recordingProvider records the objects passed to Update and Delete, and can 
be
+// told to fail a delete. Shared by the reconciler tests in this package.
 type recordingProvider struct {
+       updated   int
        deleted   []types.NamespacedName
        deleteErr error
 }
@@ -50,6 +52,7 @@ type recordingProvider struct {
 func (p *recordingProvider) Register(string, *http.ServeMux) {}
 
 func (p *recordingProvider) Update(context.Context, 
*provider.TranslateContext, client.Object) error {
+       p.updated++
        return nil
 }
 
diff --git a/internal/controller/gateway_controller_publishservice_test.go 
b/internal/controller/gateway_controller_publishservice_test.go
index 116eacf5..ec368db8 100644
--- a/internal/controller/gateway_controller_publishservice_test.go
+++ b/internal/controller/gateway_controller_publishservice_test.go
@@ -19,7 +19,6 @@ package controller
 
 import (
        "context"
-       "net/http"
        "testing"
 
        "github.com/go-logr/logr"
@@ -41,24 +40,8 @@ import (
        "github.com/apache/apisix-ingress-controller/api/v1alpha1"
        "github.com/apache/apisix-ingress-controller/internal/controller/config"
        "github.com/apache/apisix-ingress-controller/internal/controller/status"
-       "github.com/apache/apisix-ingress-controller/internal/provider"
 )
 
-// recordingProvider counts data plane pushes so tests can assert whether a
-// reconcile reached Provider.Update.
-type recordingProvider struct {
-       updated int
-}
-
-func (p *recordingProvider) Update(context.Context, 
*provider.TranslateContext, client.Object) error {
-       p.updated++
-       return nil
-}
-func (p *recordingProvider) Delete(context.Context, client.Object) error { 
return nil }
-func (p *recordingProvider) Start(context.Context) error                 { 
return nil }
-func (p *recordingProvider) NeedLeaderElection() bool                    { 
return false }
-func (p *recordingProvider) Register(string, *http.ServeMux)             {}
-
 type recordingUpdater struct {
        updates []status.Update
 }