janiussyafiq opened a new pull request, #1009:
URL: https://github.com/apache/apisix-helm-chart/pull/1009
Closes #946. Carries the fix from #968 (commit kept with its author), plus a
chart version bump so it ships.
`charts/apisix-ingress-controller/templates/pdb.yaml` includes
`apisix-ingress-controller.{fullname,labels,selectorLabels}`, but
`_helpers.tpl` only defines the `apisix-ingress-controller-manager.*` names, so
`podDisruptionBudget.enabled=true` with more than one replica fails to render:
```
helm template t apisix-ingress-controller --repo
https://apache.github.io/apisix-helm-chart \
--set podDisruptionBudget.enabled=true --set deployment.replicas=2
# Error: ... no template "apisix-ingress-controller.fullname" associated
with template "gotpl"
```
Changes:
- use the defined `apisix-ingress-controller-manager.*` helpers; the PDB
selector now matches the Deployment's selector labels
- bump `apisix-ingress-controller` to 1.3.1 (chart-only fix, `appVersion`
stays 2.2.0)
Verified locally: `ct lint` passes, and the PDB renders with the
Deployment's selector labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
