membphis commented on a change in pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#discussion_r517733960
##########
File path: api/conf/conf.json
##########
@@ -10,6 +10,17 @@
"dag-lib-path": "",
"etcd": {
"endpoints": "127.0.0.1:2379"
+ },
+ "log": {
+ "error_log": {
+ "level": "warn",
+ "file_path": ""
Review comment:
> empty string means don't save to a file.
I do not think that is a good design.
How about this way?
```sh
# case 1:
file_path = "logs/error.log" # write error log to file `./logs/error.log`
in current work dir
# case 2:
file_path = "/tmp/logs/error.log" # write error log to file
`/tmp/logs/error.log`
# case 3:
file_path = "/dev/stdout" # print the error log to stand output device
# case 4
file_path = "/dev/stderr" # print the error log to error output device
```
For an empty string, it should be an invalid value, if the user uses this
value, we'll throw an error message.
@nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
